refactor: migrate bfgs to new style learner creation #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgerrits
force-pushed
the
jagerrit/migrate_bfgs
branch
from
2a6f58a
to
cb93f6f
Compare
olgavrou
reviewed
Apr 8, 2021
| @@ -764,25 +764,25 @@ struct common_learner_builder | |||
|
|
|||
| FluentBuilderT& set_finish(void (*fn_ptr)(DataT&)) | |||
| { | |||
| _learner->finisher_fd = func_data(_learner->learn_fd.data, _learner->learn_fd.base, (finish_fptr_type)(fn_ptr)); | |||
| _learner->finisher_fd = tuple_dbf(_learner->learn_fd.data, _learner->learn_fd.base, (finish_fptr_type)(fn_ptr)); | |||
There was a problem hiding this comment.
nit: tuple_dbf -> tuple_data_base_fn
There was a problem hiding this comment.
This was a bug I introduced in the original PR and was not caught because the template was not instantiated. The rename would be good but is out of scope for this change
olgavrou
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.